decouple suspension of propagation and resourcebinding #5974
+86
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
karmada-bot
requested review from
a7i,
RainbowMango,
whitewindmills and
XiShanYongYe-Chang
karmada-bot
added
the
size/M
karmada-bot
added
size/L
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5974 +/- ##
==========================================
+ Coverage 48.25% 48.26% +0.01%
==========================================
Files 664 665 +1
Lines 54749 54793 +44
==========================================
+ Hits 26417 26445 +28
- Misses 26618 26633 +15
- Partials 1714 1715 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -322,6 +322,11 @@ type BindingSnapshot struct { | |||
| Clusters []TargetCluster `json:"clusters,omitempty"` | |||
| } | |||
|
|
|||
| // Suspension defines the policy for suspending of propagation and suspension of resource binding itself. | |||
| type Suspension struct { | |||
| *policyv1alpha1.Suspension `json:",inline"` | |||
There was a problem hiding this comment.
Can you remind me why use a pointer type of pkg/apis/work/v1alpha2/binding_types.go?
There was a problem hiding this comment.
We can seperate it's not set or set a zero value by user.
There was a problem hiding this comment.
One question is, if it is to understand the coupling, why not re-declar all the fields in the binding. What if ScheduleSuspension is also exposed in the PropagationPolicy in the future, according to the current processing?
There was a problem hiding this comment.
As @RainbowMango mentioned, pp should not expose bindingSuspension now, and we can declare an independent struct to express rb's suspension, this can be done in the future.
7 tasks
| { | ||
| name: "false for nil dispatching", | ||
| args: args{ | ||
| suspension: &policyv1alpha1.Suspension{Dispatching: nil}, | ||
| suspension: &workv1alpha2.Suspension{Suspension: &policyv1alpha1.Suspension{Dispatching: nil}}, |
There was a problem hiding this comment.
Suggested change
| suspension: &workv1alpha2.Suspension{Suspension: &policyv1alpha1.Suspension{Dispatching: nil}}, | |
| suspension: &workv1alpha2.Suspension{Suspension: policyv1alpha1.Suspension{Dispatching: nil}}, |
Signed-off-by: Monokaix <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/retest The failing test is unreleated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
decouple suspension of propagation and resourcebinding, because rb and pp's suspension should be independent.
Which issue(s) this PR fixes:
Fixes #
Part of #5937
Special notes for your reviewer:
should merge this one first before #5937
Does this PR introduce a user-facing change?: