Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize the naming of karmada config in karmadactl method #5797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.

However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.

This PR aims to standardize the naming of karmada config in karmadactl installation method.

Which issue(s) this PR fixes:

Fixes part of #5363

Special notes for your reviewer:

karmada-agent is a bit different, this PR doesn't include the rename of karmada-agent

Does this PR introduce a user-facing change?:

`karmadactl`: standardize the naming of karmada config in karmadactl installation method

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign prodanlabs, wuyingjun-lucky for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 9, 2024
@chaosi-zju
Copy link
Member Author

test report:

$ kubectl get pods -o wide -A
NAMESPACE            NAME                                                            READY   STATUS    RESTARTS   AGE     IP           NODE                                    NOMINATED NODE   READINESS GATES
karmada-system       etcd-0                                                          1/1     Running   0          34m     10.4.0.5     karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-aggregated-apiserver-669cb58ff4-tcjmg                   1/1     Running   0          33m     10.4.0.7     karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-apiserver-799cfbb68f-mm8rd                              1/1     Running   0          34m     10.4.0.6     karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-controller-manager-7c54ff558b-f5zvn                     1/1     Running   0          32m     10.4.0.10    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-descheduler-676b87df5d-swbvp                            1/1     Running   0          9m17s   10.4.0.13    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-metrics-adapter-6b88554dc8-szqhq                        1/1     Running   0          9m15s   10.4.0.14    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-scheduler-59764b9985-vgtmg                              1/1     Running   0          32m     10.4.0.9     karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-scheduler-estimator-member4-6c66449d5d-2tqwv            1/1     Running   0          79s     10.4.0.15    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-search-56767867fc-jhxch                                 1/1     Running   0          9m20s   10.4.0.12    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       karmada-webhook-b468fdcf4-m2zwv                                 1/1     Running   0          31m     10.4.0.11    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-system       kube-controller-manager-857745f88b-ptqgj                        1/1     Running   0          32m     10.4.0.8     karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          coredns-6f6b679f8f-p4kxn                                        1/1     Running   0          38m     10.4.0.2     karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          coredns-6f6b679f8f-rwbl6                                        1/1     Running   0          38m     10.4.0.3     karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          etcd-karmada-karmadactl-host-control-plane                      1/1     Running   0          38m     172.18.0.7   karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          kindnet-rwfkq                                                   1/1     Running   0          38m     172.18.0.7   karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          kube-apiserver-karmada-karmadactl-host-control-plane            1/1     Running   0          38m     172.18.0.7   karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          kube-controller-manager-karmada-karmadactl-host-control-plane   1/1     Running   0          38m     172.18.0.7   karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          kube-proxy-vgwx6                                                1/1     Running   0          38m     172.18.0.7   karmada-karmadactl-host-control-plane   <none>           <none>
kube-system          kube-scheduler-karmada-karmadactl-host-control-plane            1/1     Running   0          38m     172.18.0.7   karmada-karmadactl-host-control-plane   <none>           <none>
local-path-storage   local-path-provisioner-57c5987fd4-v27d5                         1/1     Running   0          38m     10.4.0.4     karmada-karmadactl-host-control-plane   <none>           <none>

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.38462% with 29 lines in your changes missing coverage. Please review.

Project coverage is 42.99%. Comparing base (41582f8) to head (e8998f6).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/addons/init/enable_option.go 0.00% 23 Missing ⚠️
pkg/karmadactl/cmdinit/kubernetes/deploy.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5797      +/-   ##
==========================================
+ Coverage   42.84%   42.99%   +0.15%     
==========================================
  Files         656      656              
  Lines       55884    55925      +41     
==========================================
+ Hits        23944    24046     +102     
+ Misses      30391    30333      -58     
+ Partials     1549     1546       -3     
Flag Coverage Δ
unittests 42.99% <55.38%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants