fix rebalancer auto deleted failed

Signed-off-by: chaosi-zju <[email protected]>
karmada-io · Dec 28, 2024 · 078d3e6 · 078d3e6
1 parent 8fa7c2c
commit 078d3e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/controllers/workloadrebalancer/workloadrebalancer_controller.go b/pkg/controllers/workloadrebalancer/workloadrebalancer_controller.go
@@ -90,7 +90,7 @@ func (c *RebalancerController) Reconcile(ctx context.Context, req controllerrunt
 		return controllerruntime.Result{}, err
 	}
 
-	if rebalancer.Status.FinishTime == nil {
+	if newStatus.FinishTime == nil {
 		// should never reach here.
 		klog.Errorf("finishTime shouldn't be nil, current status: %+v", rebalancer.Status)
 		return controllerruntime.Result{}, nil

diff --git a/test/e2e/workloadrebalancer_test.go b/test/e2e/workloadrebalancer_test.go
@@ -193,6 +193,12 @@ var _ = framework.SerialDescribe("workload rebalancer testing", func() {
 				framework.WaitRebalancerDisappear(karmadaClient, rebalancerName)
 			})
 		})
+
+		ginkgo.It("create rebalancer with ttl and verify it can auto clean", func() {
+			rebalancer.Spec.TTLSecondsAfterFinished = ptr.To[int32](5)
+			framework.CreateWorkloadRebalancer(karmadaClient, rebalancer)
+			framework.WaitRebalancerDisappear(karmadaClient, rebalancerName)
+		})
 	})
 
 	// 2. static weight scheduling