-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow headless to use GPU #266
Conversation
I believe this test will fail with this change: https://github.com/karma-runner/karma-chrome-launcher/blob/master/test/jsflags.spec.js#L85 The flag seems to have been added from the original headless PR (6 years ago) and there's no specific note of it being load bearing so I don't see any reason for needing it. |
Thanks, updated. |
So, @barrtender do these test failures mean anything to you? I'm hoping this isn't related to my change... |
Did some investigation yesterday - I think it's just that the commit messages are in the wrong format. Can you rebase/squash the commits to get it in the standard format? I suggest: I think that would work. |
Hey Guys, Can we please merge it asap? |
Closing in favor of #266. |
Also, there's a cool feature called "Squash and Merge" on Github to avoid this problem, though I suppose there's no getting around the picky commitlint. |
Fixes #263
It seems reasonable to allow headless chrome to use the GPU if available, and on M1 macbooks it's the only thing that works now for WebGL since Chrome 109. I've verified this allows my karma tests to run again on my M1 macbook as long as I also specify the
--use-angle=metal
flag.