PLAT-24956+PLAT-24957: Add support for configuring support access mode + block login when support access not allowed #12902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e + block login when support access not allowed
…Tucana-20.20.0-PLAT-24956
…Tucana-20.20.0-PLAT-24956
|
|
||
| $allowedUntil = $this->getSupportAccessAllowedUntil(); | ||
| $allowedUntil = $allowedUntil ? $allowedUntil : (time() - 3600); | ||
| return (time() < $allowedUntil); |
There was a problem hiding this comment.
in the case you set allowedUntil= time() - 3600 this condition in line 2466 will always be false, is this intended?
| @@ -523,6 +523,10 @@ class KalturaErrors extends APIErrors | |||
| const PROPERTY_IS_NOT_DEFINED = "PROPERTY_IS_NOT_DEFINED;PROP,TYPE;The property \"@PROP@\" is not defined on type \"@TYPE@\""; | |||
|
|
|||
| const GROUPS_CANNOT_CO_EXIST = "GROUPS_CANNOT_CO_EXIST;userId,group,blockedCoExist;Cannot add user [@userId@] to group [@group@], User is already member of a group with coexistence enforcement [@blockedCoExist@]"; | |||
|
|
|||
| const CAN_ONLY_BE_UPDATED_BY_ACCOUNT_OWNER = "CAN_ONLY_BE_CHANGED_BY_ACCOUNT_OWNER;;Support access mode can only be updated by the account owner"; | |||
There was a problem hiding this comment.
i would chose either changed/updated and use one terminology for all
| @@ -210,6 +210,10 @@ public function getAdminSessionAction($pId, $userId = null) | |||
| $userId = $dbPartner->getAdminUserId(); | |||
| } | |||
|
|
|||
| if(!$dbPartner->isSupportAccessAllowed()) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.