Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-14058): Playlist - Loading Youtube and Image entries throws an error #789

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(FEC-14058): Playlist - Loading Youtube and Image entries throws an error #789

merged 1 commit into from
Jul 22, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

Description of the Changes

Add validation for call to engine setCachedUrls, since non html5 engines don't have this API

Resolves FEC-14058

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit 31130fe into master Jul 22, 2024
11 checks passed
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-14058 branch July 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @lianbenjamin