Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ADA-6): v7 player (accessibility) - Frames for Video Players Aren't Labeled #787

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Jun 23, 2024

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

Issue:
Iframe elements are labeled with uiConf/xxxxxx (the last parameter in the src url) in iframe lists (on screen readers) and not name.

Solution:
Add title element with the entry name

Solves ADA-6

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/player.ts Outdated Show resolved Hide resolved
src/player.ts Show resolved Hide resolved
src/player.ts Show resolved Hide resolved
src/player.ts Show resolved Hide resolved
@Tzipi-kaltura Tzipi-kaltura merged commit d4ffe97 into master Jul 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants