Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-42112): Advanced Caption Settings not working in iOS #783

Merged
merged 6 commits into from
Jul 7, 2024
Merged

fix(SUP-42112): Advanced Caption Settings not working in iOS #783

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28cff03
fix(SUP-42112): Advanced Caption Settings not working in iOS
inbalvasserman Apr 1, 2024
755c6b5
Merge branch 'master' into SUP-42112
inbalvasserman Apr 16, 2024
0d5fe5f
fix(SUP-42112): Advanced Caption Settings not working in iOS
inbalvasserman Apr 16, 2024
1dd594f
remove unused change in background
inbalvasserman Apr 16, 2024
fa223ff
change background to be only behind the captions and not on all the line
inbalvasserman Jun 9, 2024
c70c593
remove space
inbalvasserman Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/track/text-style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,8 @@ class TextStyle {
attributes.push('text-align: ' + this.textAlign);
attributes.push('font-family: ' + this.fontFamily);
attributes.push('color: ' + TextStyle.toRGBA(this.fontColor, this.fontOpacity));
attributes.push('background-color: ' + TextStyle.toRGBA(this.backgroundColor, this.backgroundOpacity));
attributes.push(`background: linear-gradient(0deg, ${TextStyle.toRGBA(this.backgroundColor, this.backgroundOpacity)}, ${TextStyle.toRGBA(this.backgroundColor, this.backgroundOpacity)})`);
attributes.push('font-size: ' + this.fontSize);
attributes.push('text-shadow: ' + this.getTextShadow());
return attributes.join('!important; ');
}
Expand Down
Loading