Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore window object where needed #748

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fix: restore window object where needed #748

merged 1 commit into from
Jan 7, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

Description of the Changes

Restore window.* to protect against missing properties on the global context

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit 22c594e into master Jan 7, 2024
11 checks passed
@SivanA-Kaltura SivanA-Kaltura deleted the restore-window branch January 7, 2024 13:06
@MosheMaorKaltura MosheMaorKaltura restored the restore-window branch January 18, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheMaorKaltura MosheMaorKaltura MosheMaorKaltura approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @MosheMaorKaltura