Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove source tag before config is reset #740

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: remove source tag before config is reset #740

merged 2 commits into from
Dec 1, 2023

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 30, 2023

Description of the Changes

the logic of removing source tag depends on config which is reset in the super destroy method so need to run it before

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@MosheMaorKaltura MosheMaorKaltura merged commit e413c40 into master Dec 1, 2023
3 checks passed
@MosheMaorKaltura MosheMaorKaltura deleted the fix/RemoveVideoSourceChildNode2 branch December 1, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheMaorKaltura MosheMaorKaltura MosheMaorKaltura approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @MosheMaorKaltura