Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-39574): Enable captions button is not working #725

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

the issue:
when the textLanguage config is defined to "auto" and there is no previous language in the localSession when clicking on enable caption button nothing happen.

root cause:
trying to find track with "auto" language and not real language

the solution:
when "captionsDisplay" is disabled change the attribute state to defaultLanguage (the playbackConfig.textLanguage after set the language for "auto")

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 1f66b30 into master Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants