fix(FEC-14076): Player v7 | Download | Download notification popup is being display behind download overlay. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
requested review from
MosheMaorKaltura,
semarche-kaltura,
lianbenjamin and
JonathanTGold
lianbenjamin
approved these changes
Aug 1, 2024
| @@ -1,10 +1,11 @@ | |||
| .toastsContainer { | |||
| position: absolute; | |||
| z-index: 9999; | |||
There was a problem hiding this comment.
i suggest to put a reasonable number, otherwise, we might get into infinite numbers,
and this is prone to error (the next one will set 100 and expect to be above all)
somthing like 5 (just need to search globally in the project to figure out the current max)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Change the toasts container z index from 2 to 9999 to make it appear on top of everything else
Related PR: kaltura/playkit-js-ui#916
Resolves: FEC-14076
CheckLists