Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13991): handle initial size of detach window #57

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix(FEC-13991): handle initial size of detach window #57

merged 1 commit into from
Jun 6, 2024

Conversation

semarche-kaltura
Copy link
Contributor

@semarche-kaltura semarche-kaltura commented Jun 6, 2024 •
edited
Loading

Description of the Changes

New window auto-resizes to content size. The changes prevents send initial size of the new window as resize event.

resolves: https://kaltura.atlassian.net/browse/FEC-13991

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@semarche-kaltura semarche-kaltura merged commit 596cd86 into master Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

@lianbenjamin lianbenjamin Awaiting requested review from lianbenjamin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semarche-kaltura @SivanA-Kaltura