Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-13686): add detach/attach types #55

Merged
merged 8 commits into from
May 21, 2024
Merged

feat(FEC-13686): add detach/attach types #55

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4de8e28
feat(FEC-13686): detach MVP
semarche-kaltura May 6, 2024
4d39c5c
feat(FEC-13686): detach API
semarche-kaltura May 13, 2024
c3b2e59
fix lint errors
semarche-kaltura May 15, 2024
68197fb
fix(FEC-13942): focus new window
semarche-kaltura May 15, 2024
586ea6b
fix PR comments
semarche-kaltura May 21, 2024
330540c
Merge commit 'ef829ef6c01d2ef5168450bb156e186ed2578520' into FEC-1368…
semarche-kaltura May 21, 2024
a4f793d
fix(FEC-13686): types upgrade
semarche-kaltura May 21, 2024
8aa5d90
Merge commit '51e308791e3874df4a7bc0cce3fc2ba4c9c6c2fa' into FEC-1368…
semarche-kaltura May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion types/modules.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,32 @@ declare module "services/side-panels-manager/models/side-panel-item" {
readonly position: PlaykitUI.SidePanelPosition;
readonly expandMode: PlaykitUI.SidePanelMode;
}
export const DETACHED_WINDOW_STYLES: {
margin: string;
backgroundColor: string;
};
export const DETACH_CONTAINER_CLASS = "playkit-player detach-sidebar-container";
export const CLOSE_DETACH_EVENTS: string[];
}
declare module "services/side-panels-manager/ui/panel-item-wrapper/panel-item-wrapper.component" { }
declare module "services/side-panels-manager/models/item-wrapper" { }
declare module "services/side-panels-manager/models/item-wrapper" {
import { FunctionalComponent, ComponentClass } from 'preact';
export interface DetachWindowOptions {
onAttach?: () => void;
top?: number;
left?: number;
width: number;
height: number;
title: string;
maxWidth?: number;
maxHeight?: number;
attachPlaceholder?: ComponentClass | FunctionalComponent;
}
}
declare module "services/side-panels-manager/side-panels-manager" {
import { KalturaPlayer, Logger } from '@playkit-js/kaltura-player-js';
import { SidePanelItem } from "services/side-panels-manager/models/side-panel-item";
import { DetachWindowOptions } from "services/side-panels-manager/models/item-wrapper";
export class SidePanelsManager {
private readonly player;
private readonly activePanels;
Expand All @@ -31,6 +51,10 @@ declare module "services/side-panels-manager/side-panels-manager" {
activateItem(itemId: number): void;
deactivateItem(itemId: number): void;
isItemActive(itemId: number): boolean;
isItemDetached(itemId: number): boolean;
detachItem(itemId: number, options: DetachWindowOptions): void;
attachItem(itemId: number): void;
getDetachedRef(itemId: number): HTMLDivElement;
/**
* Rerender (uses preact Component.forceUpdate api under the hoods) the side panel item component
* It's just for backward compatibility you should not use it.
Expand Down
Loading