fix(FEC-13517): Wrong and inconsistent order of plugins & Plugins buttons sometimes display with the wrong icon #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tons sometimes display with the wrong icon
This was referenced Jan 16, 2024
…ically at run time based on the supplied order param while calling add icon API
SivanA-Kaltura
requested changes
Jan 18, 2024
semarche-kaltura
requested changes
Jan 18, 2024
semarche-kaltura
previously approved these changes
Jan 23, 2024
JonathanTGold
added a commit
to kaltura/playkit-js-transcript
that referenced
this pull request
Jan 24, 2024
fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-share
that referenced
this pull request
Jan 24, 2024
### Description of the Changes **fix: Wrong and inconsistent order of plugins** **fix: Plugins buttons sometimes display with the wrong icon** **solves: [FEC-13517](https://kaltura.atlassian.net/browse/FEC-13517) [FEC-13517](https://kaltura.atlassian.net/browse/FEC-13517)** [FEC-13517]: https://kaltura.atlassian.net/browse/FEC-13517?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FEC-13517]: https://kaltura.atlassian.net/browse/FEC-13517?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ #### Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-navigation#348 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-moderation
that referenced
this pull request
Jan 24, 2024
Description of the Changes fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-playlist
that referenced
this pull request
Jan 24, 2024
### Description of the Changes **fix: Wrong and inconsistent order of plugins** **fix: Plugins buttons sometimes display with the wrong icon** **solves: [FEC-13517](https://kaltura.atlassian.net/browse/FEC-13517) [FEC-13517](https://kaltura.atlassian.net/browse/FEC-13517)** [FEC-13517]: https://kaltura.atlassian.net/browse/FEC-13517?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FEC-13517]: https://kaltura.atlassian.net/browse/FEC-13517?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ #### Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-navigation
that referenced
this pull request
Jan 24, 2024
fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-info#90 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-info
that referenced
this pull request
Jan 24, 2024
…tons sometimes display with the wrong icon (#90) fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-qna
that referenced
this pull request
Jan 24, 2024
fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-downloads#39 -------------------------------------------------------------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-related
that referenced
this pull request
Jan 24, 2024
fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-navigation#348 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-downloads
that referenced
this pull request
Jan 24, 2024
fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-related#61 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
fix: Wrong and inconsistent order of plugins
fix: Plugins buttons sometimes display with the wrong icon
fix: Decoupling the UpperBarManager and sidePanelBarManager services , Removing all UpperBarManager related logic from sidePanelBarManager
fix: fix Demo test pages of both (UpperBarManager and sidePanelBarManager services)
refactor: decoupling plugins order config from ui-managers and setting it dynamically at run time based on the supplied order param while calling add icon API
solves: FEC-13517 FEC-13517
Related Prs
kaltura/playkit-js-transcript#175
kaltura/playkit-js-share#38
kaltura/playkit-js-moderation#74
kaltura/playkit-js-playlist#53
kaltura/playkit-js-related#61
kaltura/playkit-js-info#90
kaltura/playkit-js-navigation#348
kaltura/playkit-js-downloads#39
kaltura/playkit-js-qna#334