Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-13490): Move manager services from common into ui-managers #48

Merged
merged 14 commits into from
Dec 11, 2023

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Nov 28, 2023

Description of the Changes

Move managers from common to ui-managers

Related PRs:
kaltura/playkit-js-common#40
kaltura/playkit-js-qna#331
kaltura/playkit-js-hotspots#310
kaltura/playkit-js-moderation#65
kaltura/playkit-js-downloads#34
kaltura/playkit-js-ivq#110
kaltura/playkit-js-call-to-action#3

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/services/floating-manager/floating-manager.tsx Outdated Show resolved Hide resolved
src/services/preset-manager/preset-manager.tsx Outdated Show resolved Hide resolved
src/services/preset-manager/preset-manager.tsx Outdated Show resolved Hide resolved
src/services/preset-manager/preset-manager.tsx Outdated Show resolved Hide resolved
src/services/toast-manager/ui/toast/toast.tsx Outdated Show resolved Hide resolved
src/services/toast-manager/ui/toasts-container/index.ts Outdated Show resolved Hide resolved
@SivanA-Kaltura SivanA-Kaltura merged commit 4660a3f into master Dec 11, 2023
3 checks passed
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-13490 branch December 11, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants