Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-13517): Wrong and inconsistent order of plugins #39

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(FEC-13517): Wrong and inconsistent order of plugins #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/download.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {DownloadPluginManager} from './download-plugin-manager';

import {OnClickEvent} from '@playkit-js/common';
import {ui} from '@playkit-js/kaltura-player-js';
const {Text} = ui.preacti18n;
import { pluginName } from "./index";
const {ReservedPresetNames} = ui;
const PRESETS = [ReservedPresetNames.Playback, ReservedPresetNames.Img];

Expand Down Expand Up @@ -79,10 +79,15 @@ class Download extends KalturaPlayer.core.BasePlugin {
return;
}

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
this.iconId = this.upperBarManager.add({
label: (<Text id="download.download">Download</Text>) as never,
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
ariaLabel: (<Text id="download.download">Download</Text>) as never,
displayName: 'Download',
order: 40,
svgIcon: {
viewBox: '0 0 32 32',
path: DOWNLOAD
},
onClick: this._handleClick as any,
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ const NAME = __NAME__;
export {Download as Plugin};
export {VERSION, NAME};

const pluginName = 'download';
export const pluginName = 'download';

KalturaPlayer.core.registerPlugin(pluginName, Download);