Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export storage managers from player #731

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Jan 31, 2024

Description of the Changes

Expose managers and trigger type generation

Required for FEC-13504

@JonathanTGold JonathanTGold self-requested a review February 4, 2024 15:16
Copy link
Contributor

@JonathanTGold JonathanTGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@JonathanTGold JonathanTGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly the purpose os exporting these managers?
I think the browser storage should be managed only in kaltura level

@SivanA-Kaltura
Copy link
Contributor Author

SivanA-Kaltura commented Feb 5, 2024

@JonathanTGold For FEC-13504, I need to add code in a plugin to save a value in session config, and i want to do it through the session storage manager

@SivanA-Kaltura SivanA-Kaltura merged commit 8a56dee into master Feb 6, 2024
11 checks passed
@SivanA-Kaltura SivanA-Kaltura deleted the expose-session-storage-mgr branch February 6, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants