Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spec_kst_to_all to build-tests and better document process of testing #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Apr 6, 2024

In the #108 (comment) @generalmimon was not against to removing existing build-tests script which is not very useful. On the other hand, spec_kst_to_all script which is actually useful:

  • named unclear
  • contains underscores which are slightly inconvenient to enter (requires pressing SHIFT + - in QWERTY layout)

This PR solves both problems by removing the old build-tests script and renaming spec_kst_to_all script to build-tests. It also updates documentation, because I find it is difficult to have documentation of how to run tests far away from tests itself in other repository (https://github.com/kaitai-io/kaitai_struct_doc/blob/c87ae4cb447abfb043bcbade1c8d601037469142/kst.adoc).

I also described directories that was not described to have the full picture in the Readme.

This PR should be merged together with kaitai-io/kaitai_struct_doc#55 to update mentioned kst.adoc.

@Mingun
Copy link
Contributor Author

Mingun commented Aug 20, 2024

@generalmimon , is it possible to merge this PR? It greatly simplifies developing process, because you should not remember to make sbt publishLocal after building compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant