Feat: 공연 예매/지원자 통계 조회 API #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woogieon8on
reviewed
Nov 14, 2024
| GraphResponse graph, | ||
| @Schema(description = "총 수입", example = "1000000") | ||
| Long totalIncome | ||
| ) { |
There was a problem hiding this comment.
하나의 클래스로 관련된 DTO를 관리하니까 프로젝트 구조가 간결해지는 것 같습니다
배워갑니다!!
woogieon8on
reviewed
Nov 14, 2024
| @@ -50,6 +51,8 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception { | |||
| ); | |||
| http.authorizeHttpRequests((authorize) -> authorize | |||
| .requestMatchers( "/api-docs/**", "/swagger-ui/**", "/swagger-ui.html/**", "/v3/api-docs/**", "/swagger-ui/index.html#/**").permitAll() | |||
| .requestMatchers(HttpMethod.GET, "/v1/admin/tickets/**").permitAll() | |||
| .requestMatchers(HttpMethod.GET, "/v1/admin/apply/**").permitAll() | |||
There was a problem hiding this comment.
혹시 GET 메서드 요청에 대해 permitAll() 설정을 적용하신 이유가 있을까요?
There was a problem hiding this comment.
공연정보/지원정보 조회에 대해서만 permitAll 설정을 해둔다는게 엔드포인트를 잘못작성했네요 수정하겠습니다!
kjiyun
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)