-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Separate repl into separate project, fix REPL docs output #277
Conversation
As of my last commit, it also fixes an annoying issue in the pact-5 repl that repl functions were actually going through the gas charging method, which when it actually charges gas, will essentially brick the repl. The following is now possible:
|
ee1d0b0
to
5ef5609
Compare
- Move tracing flags to repl sublibrary - Fix repl builtins charging gas on the repl
5ef5609
to
bc0ba1b
Compare
@@ -18,7 +18,7 @@ Use the following arguments to specify the test expression and error message for | |||
|
|||
| Argument | Type | Description | | |||
|----------|--------|------------------------------------------------| | |||
| `expression` | bool | Specifies the expression to evaluate. | | |||
| expression | bool | Specifies the expression to evaluate. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsgunnlsgunn last PR's added the backticks. What is the correct style now, see: https://github.com/kadena-io/pact-5/pull/278/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually understands why this breaks docusaurus, but it looks weird in our ansi terminal renderer, but lisa can add them back if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need backticks around ordinary words or words to indicate syntax, per se. We only require them for certain characters that freak Docusaurus out where the docs engine doesn't know how to interpret things like < and > or { and } except as HTML. I don't know what all the characters are that it doesn't like. Amir put something together that records them, I think.
This PR separates the REPL into its own sub-library which helpful for fixing several issues:
pandoc
, which fixes in our docs issues where our docs in the repl look like the raw markdown docs.Before this PR:
After this PR:
PR checklist:
Additionally, please justify why you should or should not do the following: