-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration: Fixes for parity replay #266
Conversation
argList = parens (hsep (pretty <$> defArgs)) | ||
in parens $ deftoken <+> pretty dfNameArg <+> argList | ||
TLModule m -> pretty m | ||
_ -> "todo: pretty interfaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ever an instance where we'll need to prettyprint an interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably yes for debugging. Thanks for the note, I'll remember to add pretty instances.
For transparency: These pretty
instances are being used during integration work to debug the pact-5 representation of the modules read in from legacy. They're incredibly useful to see how we are deserializing things, but only modules presented a challenge, since interfaces are relatively simple.
29862dd
to
01609a2
Compare
Not having this data type is causing a replay failure during parity replay
01609a2
to
2a8a9ad
Compare
2a8a9ad
to
9266417
Compare
PR checklist:
Additionally, please justify why you should or should not do the following: