Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Fixes for parity replay #266

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Integration: Fixes for parity replay #266

merged 10 commits into from
Oct 21, 2024

Conversation

jmcardon
Copy link
Member

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

argList = parens (hsep (pretty <$> defArgs))
in parens $ deftoken <+> pretty dfNameArg <+> argList
TLModule m -> pretty m
_ -> "todo: pretty interfaces"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever an instance where we'll need to prettyprint an interface?

Copy link
Member Author

@jmcardon jmcardon Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes for debugging. Thanks for the note, I'll remember to add pretty instances.

For transparency: These pretty instances are being used during integration work to debug the pact-5 representation of the modules read in from legacy. They're incredibly useful to see how we are deserializing things, but only modules presented a challenge, since interfaces are relatively simple.

@jmcardon jmcardon marked this pull request as draft October 20, 2024 23:09
@jmcardon jmcardon marked this pull request as ready for review October 21, 2024 19:05
pact/Pact/Core/IR/Eval/CEK/Evaluator.hs Outdated Show resolved Hide resolved
pact/Pact/Core/IR/Eval/CEK/Evaluator.hs Outdated Show resolved Hide resolved
pact/Pact/Core/Gas/Utils.hs Outdated Show resolved Hide resolved
pact/Pact/Core/IR/Eval/CEK/CoreBuiltin.hs Show resolved Hide resolved
pact/Pact/Core/SizeOf.hs Show resolved Hide resolved
@jmcardon jmcardon merged commit 4a655db into master Oct 21, 2024
11 checks passed
@jmcardon jmcardon deleted the jose/fix-xresume branch October 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants