Get the typed core to compile #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors IR.IfDefun.
…tion But that's worth double-checking later on.
Previously, `inferModule` was inferring the types of the definitions in the module sequentially, taking into account the previously inferred types when inferring each next one. Now, 1. All top-level types are supposed to be annotated in IR as well, so there should be no reliance on the inferred types of the other definitions in the module. 2. The types of inferred (`Typed`) and non-inferred (`IR`) defs are different, and it's easy to see from types that the inference engine only depends on the non-inferred `IR` ones anyway, so looks like there's no need (and no easy way!) to keep the inferred ones in context as well. 3. Depending on the order seems funny anyway.
Just don't update `Loaded` with the same motivation.
…ering Hence desugar them.
nix caching fix - x86 ubuntu/mac, m1 mac
|
This PR is great and I will cherry pick some changes. It's a bit too much work to revive with all the changes to the core compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's plenty of work to be done still, but at least it compiles now, and I'd like to get it merged to avoid merge conflicts in the future.
There are also some a bit questionable design decisions I had to make, so we might want to discuss that later.