Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clusterName label for identify each kubernetes cluster where K8UP is deployed #1030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lenglet-k
Copy link

@lenglet-k lenglet-k commented Dec 9, 2024

Summary

We use K8up on multiple clusters. These multiple clusters perform backups of namespaces with the same name. All the metrics are sent in the same pushgateway.

As the metrics have the same labels, we cannot have a detailed overview by cluster. This is the way K8UP currently works, which does not allow metric labels to be overloaded. This PR makes it possible to add a clusterName label per Kubernetes cluster.

So in pushgateway we have backup metrics per Kubernetes cluster and per namespace, which improves monitoring of the execution of backups per Kubernetes cluster.

I essentially added a clusterName variable equivalent to the promUrl variable.

See: #1031

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Commits are signed off
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

@lenglet-k lenglet-k requested a review from a team as a code owner December 9, 2024 13:57
@lenglet-k lenglet-k requested review from Kidswiss and zugao and removed request for a team December 9, 2024 13:57
@lenglet-k lenglet-k force-pushed the feat/add-clusterName branch from 944b4c3 to f7d2ddf Compare December 9, 2024 13:58
@lenglet-k lenglet-k changed the title change: add clusterName label for identify each kubernetes cluster where K8UP is deployed feat: add clusterName label for identify each kubernetes cluster where K8UP is deployed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant