Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parallel restart of all already bootstrapped nodes #673

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Jul 8, 2024

What this PR does:
If cassandra.datastax.com/allow-parallel-starts: true is set, the cass-operator will check first for all nodes that have previously bootstrapped but are down and then try to restart them.

This happens before we try to start any other node in the normal process.

Which issue(s) this PR fixes:
Fixes #646

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm marked this pull request as ready for review July 9, 2024 07:06
@burmanm burmanm requested a review from a team as a code owner July 9, 2024 07:06
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Could you take a look at the failing tests before merging?
Thanks!

@burmanm
Copy link
Contributor Author

burmanm commented Jul 10, 2024

Both failing tests are expected and one requires a fix in the mgmt-api (it's not cass-operator failure, but the fix is not released yet).

@burmanm burmanm merged commit 14ce1a9 into k8ssandra:master Jul 10, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the recovery when an existing node crashes during an expansion
2 participants