Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release changes to use prefixed repositories #559

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Aug 7, 2023

What this PR does:
cr.k8ssandra.io prefix for all deployed images from k8ssandra/* and cr.dstx.io for all deployed images from datastax/*

Resulting image_config.yaml:

apiVersion: config.k8ssandra.io/v1beta1
kind: ImageConfig
metadata:
  name: image-config
images:
  system-logger: "cr.k8ssandra.io/k8ssandra/system-logger:latest"
  config-builder: "cr.dtsx.io/datastax/cass-config-builder:1.0-ubi7"
  # cassandra:
  #   "4.0.0": "k8ssandra/cassandra-ubi:latest"
  # dse:
  #   "6.8.999": "datastax/dse-server-prototype:latest"
# imageRegistry: "localhost:5000"
# imagePullPolicy: Always
# imagePullSecret:
#   name: my-secret-pull-registry
defaults:
  # Note, postfix is ignored if repository is not set
  cassandra:
    repository: "cr.k8ssandra.io/k8ssandra/cass-management-api"
    suffix: "-ubi8"
  dse:
    repository: "cr.dtsx.io/datastax/dse-mgmtapi-6_8"
    suffix: "-ubi8"

Which issue(s) this PR fixes:
Fixes #479

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner August 7, 2023 09:27
yq eval -i '.images.config-builder |= "cr.dtsx.io/" + .' config/manager/image_config.yaml
yq eval -i '.defaults.dse.repository |= "cr.dtsx.io/" + .' config/manager/image_config.yaml

# cr.dstx.io/datastax/dse-mgmtapi-6_8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: You could remove this comment, it's unclear why it was kept here.

Prefix all deployed images with cr.k8ssandra.io or cr.dstx.io in tagged releases

Fix to use cr.dtsx.io and not cr.dstx.io, update integ-test to use 6.8.37-ubi8 instead of 6.8.29

Add CHANGELOG for 479
@burmanm burmanm merged commit 5189beb into k8ssandra:master Oct 20, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace default images for DSE
2 participants