-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: remotefs/download support file download #194
Open
kaplan-michael
wants to merge
3
commits into
k0sproject:main
Choose a base branch
from
kaplan-michael:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kke PTAL. |
kke
reviewed
May 6, 2024
kke
reviewed
May 7, 2024
kaplan-michael
force-pushed
the
main
branch
3 times, most recently
from
May 14, 2024 15:47
ffcfd4c
to
8f0b4b2
Compare
kke
reviewed
May 15, 2024
@kke can we merge this then? |
kke
reviewed
May 22, 2024
kke
reviewed
May 22, 2024
kke
reviewed
May 22, 2024
kke
reviewed
May 22, 2024
kke
reviewed
May 22, 2024
Signed-off-by: Michael Kaplan <[email protected]>
Signed-off-by: Michael Kaplan <[email protected]>
Signed-off-by: Michael Kaplan <[email protected]>
@kke I have cleaned it up, so we should now be good to go(unless I missed something) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support downloading files from hosts.
#193