Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: remotefs/download support file download #194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kaplan-michael
Copy link

@kaplan-michael kaplan-michael commented Apr 29, 2024

Support downloading files from hosts.
#193

@kaplan-michael kaplan-michael marked this pull request as ready for review May 4, 2024 23:43
@kaplan-michael
Copy link
Author

@kke PTAL.

remotefs/download.go Outdated Show resolved Hide resolved
remotefs/downloaddirectory.go Outdated Show resolved Hide resolved
@kaplan-michael kaplan-michael force-pushed the main branch 3 times, most recently from ffcfd4c to 8f0b4b2 Compare May 14, 2024 15:47
@kaplan-michael
Copy link
Author

@kke can we merge this then?

remotefs/download.go Outdated Show resolved Hide resolved
remotefs/download.go Outdated Show resolved Hide resolved
remotefs/download.go Outdated Show resolved Hide resolved
remotefs/downloaddirectory.go Outdated Show resolved Hide resolved
remotefs/uploaddirectory.go Outdated Show resolved Hide resolved
@kaplan-michael
Copy link
Author

@kke I have cleaned it up, so we should now be good to go(unless I missed something)

@kaplan-michael kaplan-michael requested a review from kke August 20, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants