report status of k0smotroncontrolplane replicas #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedriza
force-pushed
the
report-k0smotron-cluster-version
branch
from
45cc74f to
530d09f
Compare
apedriza
changed the title
apedriza
force-pushed
the
report-k0smotron-cluster-version
branch
3 times, most recently
from
9237196 to
4644eaf
Compare
Signed-off-by: Adrian Pedriza <[email protected]>
apedriza
force-pushed
the
report-k0smotron-cluster-version
branch
from
4644eaf to
aef2b98
Compare
juanluisvaladas
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #819
From CAPI contract: https://cluster-api.sigs.k8s.io/developer/providers/contracts/control-plane#:~:text=needs%20of%20your%20provider.%0A%7D-,Following%20fields%20MUST%20be%20implemented%20in%20the%20ControlPlane%20status.,-type%20FooControlPlaneStatus%20struct%20%7B%0A%20%20%20%20//%20selector
Contract takes into account machines exists for controlplane but in this case for k0smotron, pods are the instances to look for status reporting.