Add controlplane upgrade e2e test using capi framework #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedriza
force-pushed
the
add-capi-e2e-framework
branch
16 times, most recently
from
c68dc94 to
c81ecf9
Compare
Signed-off-by: Adrian Pedriza <[email protected]>
apedriza
force-pushed
the
add-capi-e2e-framework
branch
from
c81ecf9 to
39692b5
Compare
apedriza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #775
This PR makes use of the e2e framework built by CAPI and used by several providers. This is intended to address current problems described in this issue such as code repetition or a proper collection of logs in case of failure. By adopting this framework, much of the code required for each test (such as test environment creation) is imported from the CAPI framework. On the other hand, a log dump of all relevant test components logs + configuration used is implemented if the test fails, improving the debugging capability of the test in case of failure. It also improves the ability to test against different infra providers, making use of an appropriate configuration file. In general, this approach makes e2e testing quite configurable.
The idea is as more e2e tests are added, to properly build CI using the parallelism feature (if needed in the test) and combine it with the test execution using Github Actions matrix feature. For now, a basic configuration is sufficient. The intention is to migrate the current tests little by little from the current approach to the proposed one.