K0sControlPlane admission webhook #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhov
force-pushed
the
admission-hook
branch
2 times, most recently
from
2195d6b to
db4c512
Compare
makhov
force-pushed
the
admission-hook
branch
7 times, most recently
from
2295e3f to
3e28593
Compare
Signed-off-by: Alexey Makhov <[email protected]>
makhov
force-pushed
the
admission-hook
branch
2 times, most recently
from
01a1cfa to
d11ab59
Compare
Signed-off-by: Alexey Makhov <[email protected]>
makhov
force-pushed
the
admission-hook
branch
from
d11ab59 to
325d339
Compare
apedriza
reviewed
Dec 19, 2024
Comment on lines
+90
to
+100
| if kcp.Spec.UpdateStrategy == v1beta1.UpdateRecreate { | ||
|
|
||
| // If the cluster is running in single mode, we can't use the Recreate strategy | ||
| if kcp.Spec.K0sConfigSpec.Args != nil { | ||
| for _, arg := range kcp.Spec.K0sConfigSpec.Args { | ||
| if arg == "--single" { | ||
| return fmt.Errorf("UpdateStrategy Recreate strategy is not allowed when the cluster is running in single mode") | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
can we remove this block from machine scale reconciliation?
|
I am trying to test the webhook by deploying the development version but it doesn't seem to run, even though I force an error with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple admission webhook that declines clusters in single mode and update strategy "Recreate"