Remove some dependecies on k0s #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanluisvaladas
force-pushed
the
capi-ctrlplane-docker-downscaling-deps
branch
3 times, most recently
from
ecfc286 to
65d1b52
Compare
This was referenced Sep 6, 2024
juanluisvaladas
force-pushed
the
capi-ctrlplane-docker-downscaling-deps
branch
2 times, most recently
from
39ea532 to
47e8d6e
Compare
This commit is the first of many to remove the dependency of github.com/k0sproject/k0s. So far, we're removing github.com/k0sproject/k0s/inttest/common in every test that doesn't depend on FootlooseSuite. There have been a couple modifications due to deprecation and due to incompatibilities with macOS. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
capi-ctrlplane-docker-downscaling-deps
branch
from
47e8d6e to
bc7562c
Compare
makhov
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first and easiest part of the efforts of #711.
It removes the dependency of github.com/k0sproject/k0s/inttest/common for every test that doesn't rely on it for
common.FootlooseSuite