Do not use default 6443 port for kube-apiserver in the container #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner" This reverts commit 8d67a47.
Instead allow kube-apiserver bin to bind on privileged ports Signed-off-by: Alexey Makhov <[email protected]>
jnummelin
approved these changes
Jul 2, 2024
| @@ -110,6 +111,11 @@ mkdir /etc/k0s && echo "$K0SMOTRON_K0S_YAML" > /etc/k0s/k0s.yaml | |||
| # Substitute the kine datasource URL from the env var | |||
| sed -i "s {{ .KineDataSourceURLPlaceholder }} ${K0SMOTRON_KINE_DATASOURCE_URL} g" /etc/k0s/k0s.yaml | |||
|
|
|||
| {{if .PrivilegedPortIsUsed}} | |||
There was a problem hiding this comment.
ha, didn't realize we can use dot notation for string map keys. TIL 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #603
Fixes #637
Do not use the default 6443 port for kube-apiserver in the container.
Instead allow kube-apiserver binary to bind on privileged ports