Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installFlags change detection for --enable-worker flag #803

Merged
merged 11 commits into from
Dec 2, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented Dec 2, 2024

Partially fixes some problems reported in #801

K0sctl receives the --enable-worker flag as --enable-worker=true because of how cobra works, but it itself adds the flag as --enable-worker without the value. This causes the installFlags change detection to always incorrectly detect that the flags have changed and cause a reinstall every time.

The --kubelet-extra-args is now compared separately.

Since k0s drops --force and --env from the args and modifies --data-dir, --token-file and --config during processing, those are ignored when comparing equality.

@kke kke added the bug Something isn't working label Dec 2, 2024
@kke kke changed the title Use "true" as value for "--enable-worker" Fix installFlags change detection for --enable-worker flag Dec 2, 2024
Signed-off-by: Kimmo Lehto <[email protected]>
@kke kke merged commit 0aa7b09 into main Dec 2, 2024
39 checks passed
@kke kke deleted the enable-worker-true branch December 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant