Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small improvements to inttests #5383

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 20, 2024

Description

Only use stdout when fetching the kubeconfig in GetKubeConfig. This make the command work even when it logs something to stderr.

When clientcmd.RESTConfigFromKubeConfig failed, the error was checked too late, resulting in a panic.

Be fail-fast on some bootstrap errors in one inttest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 force-pushed the inttest-improvements branch from e84d6fe to 0d1ac64 Compare December 21, 2024 00:52
@twz123 twz123 changed the title Some small improvents to inntests Some small improvents to intests Dec 21, 2024
@twz123 twz123 force-pushed the inttest-improvements branch from 0d1ac64 to 60e3c91 Compare December 21, 2024 00:54
@twz123 twz123 changed the title Some small improvents to intests Some small improvements to intests Dec 21, 2024
@twz123 twz123 force-pushed the inttest-improvements branch from 60e3c91 to 86c8f7f Compare December 21, 2024 00:55
@twz123 twz123 changed the title Some small improvements to intests Some small improvements to inttests Dec 21, 2024
Only use stdout when fetching the kubeconfig in GetKubeConfig. This make
the command work even when it logs something to stderr.

When clientcmd.RESTConfigFromKubeConfig failed, the error was checked
too late, resulting in a panic.

Be fail-fast on some bootstrap errors in one inttest.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the inttest-improvements branch from 86c8f7f to 905ee1d Compare December 21, 2024 00:57
@twz123 twz123 marked this pull request as ready for review December 21, 2024 01:21
@twz123 twz123 requested review from a team as code owners December 21, 2024 01:21
@twz123 twz123 requested review from ncopa and makhov December 21, 2024 01:21
@twz123 twz123 merged commit 08c1af7 into k0sproject:main Dec 24, 2024
89 checks passed
@twz123 twz123 deleted the inttest-improvements branch December 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants