Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on macOS in CI #5380

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Run unit tests on macOS in CI #5380

merged 4 commits into from
Dec 23, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 20, 2024

Description

  • Compile UnmountLazy just for Linux. MNT_DETACH is defined for Linux only, hence change the build tag from unix to linux and provide a fallback for everything non-Linux.
  • Provide winExecute fallback not only for Linux. This is necessary to make it compile on macOS.
  • Make unit tests pass on macOS. Skip one test that times out for unknown reasons and needs further debugging.
  • Combine the linux and windows unit test jobs into one matrix job and add a new matrix entry for macOS.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

MNT_DETACH is defined for Linux only, hence change the build tag from
unix to linux and provide a fallback for everything non-Linux.

Signed-off-by: Tom Wieczorek <[email protected]>
This is necessary to make it compile on macOS.

Signed-off-by: Tom Wieczorek <[email protected]>
Skip one test that times out for unknown reasons and needs further
debugging.

Signed-off-by: Tom Wieczorek <[email protected]>
Combine the linux and windows unit test jobs into one matrix job and add
a new matrix entry for macOS.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added enhancement New feature or request area/ci labels Dec 20, 2024
@twz123 twz123 mentioned this pull request Dec 20, 2024
16 tasks
@twz123 twz123 marked this pull request as ready for review December 20, 2024 21:46
@twz123 twz123 requested review from a team as code owners December 20, 2024 21:46
@twz123 twz123 merged commit 670c115 into k0sproject:main Dec 23, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants