Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make calls to mktemp more portable #5366

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 16, 2024

Description

mktemp does not necessarily support the XXXXXX placeholder in the middle of the template string, so move all placeholder occurrences in template strings to the end. Adjust the gitignore file accordingly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

mktemp does not necessarily support the XXXXXX placeholder in the middle
of the template string, so move all placeholder occurrences in template
strings to the end. Adjust the gitignore file accordingly.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review December 17, 2024 10:26
@twz123 twz123 requested review from a team as code owners December 17, 2024 10:26
@twz123 twz123 merged commit 25801ba into k0sproject:main Dec 19, 2024
89 checks passed
@twz123 twz123 deleted the portable-mktemp branch December 19, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants