Introduce k0s airgap bundle-artifacts #5360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that need to be resolved. |
This sub-command introduces a "k0s native" way to create airgap artifact bundles. The current way to do this requires either a Docker or containerd daemon. Even then, there are certain scenarios where the created bundles don't contain all the necessary tags, i.e. when images are referenced by both their tag and their digest. Signed-off-by: Tom Wieczorek <[email protected]>
Dog-food the new sub-command in the k0s build itself. Signed-off-by: Tom Wieczorek <[email protected]>
twz123
force-pushed
the
bundle-artifacts-cmd
branch
from
0ee98cf to
eb54146
Compare
kke
reviewed
Dec 19, 2024
| return refs, nil | ||
| } | ||
|
|
||
| func parseArtifactRefsFromSeq(refs iter.Seq[string]) (collected []reference.Named, _ error) { |
There was a problem hiding this comment.
The _ error kind of looks like the return value can be ignored.
There was a problem hiding this comment.
I'm not sure if I can follow. What would you suggest?
kke
reviewed
Dec 19, 2024
|
|
||
| buffered := bufio.NewWriter(out) | ||
| if err := bundler.Run(ctx, refs, out); err != nil { | ||
| return err |
There was a problem hiding this comment.
I could change this to return fmt.Errorf("failed to bundle artifacts: %w", err), but I'm not sure if that adds any additional insights 🤔
kke
reviewed
Dec 19, 2024
| @@ -25,12 +25,12 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| func NewAirgapListImagesCmd() *cobra.Command { | |||
| func newAirgapListImagesCmd() *cobra.Command { | |||
|
This pull request has merge conflicts that need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sub-command introduces a "k0s native" way to create airgap artifact bundles. The current way to do this requires either a Docker or containerd daemon. Even then, there are certain scenarios where the created bundles don't contain all the necessary tags, i.e. when images are referenced by both their tag and their digest.
Replace image-bundler with k0s airgap bundle-artifacts. Dog-food the new sub-command in the k0s build itself.
Type of change
How Has This Been Tested?
Checklist: