Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject unknown sub-commands for k0s airgap #5354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject unknown sub-commands for k0s airgap #5354

wants to merge 1 commit into from
+58 −7

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 13, 2024

Description

Cobra has the property of not reporting any unrecognized sub-commands and simply displaying the help page for any command that doesn't have a run function set. Overwrite this for k0s's airgap sub-command.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Reject unknown sub-commands for k0s airgap
6fe4f05 
Cobra has the property of not reporting any unrecognized sub-commands
and simply displaying the help page for any command that doesn't have a
run function set. Overwrite this for k0s's airgap sub-command.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review December 13, 2024 11:01
@twz123 twz123 requested review from a team as code owners December 13, 2024 11:01
@twz123 twz123 requested review from ncopa and jnummelin December 13, 2024 11:01
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/cli chore merge-conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123