Honor IO errors in list-images sub-command #5330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the sub-command did not interrupt the loop and returned successfully, even when it encountered IO errors while writing to standard out.
Use
strings.Builder
instead ofbytes.Buffer
: The out and err streams are always treated as strings for better readability, so it's more idiomatic to usestrings.Builder
for them. ReplaceintoLines
withstrings.Split
, asstrings.Builder
doesn't implementio.Reader,
which eliminates another helper function on the fly.Type of change
How Has This Been Tested?
Checklist: