Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse boolean for toggling the k0s endpoint reconciler #5313

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 5, 2024

Description

In the controller start function, the condition to determine whether to use the k0s endpoint reconciler was written twice in very distant parts of that function. Reuse the boolean value instead. Also, rename it to a more appropriate name: There are actually two different reconcilers at play: The default one built into the API server, and k0's own implementation of it. Make it clear which implementation the boolean refers to.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

In the controller start function, the condition to determine whether to
use the k0s endpoint reconciler was written twice in very distant parts
of that function. Reuse the boolean value instead. Also, rename it to
a more appropriate name: There are actually two different reconcilers
at play: The default one built into the API server, and k0's own
implementation of it. Make it clear which implementation the boolean
refers to.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the chore label Dec 5, 2024
@twz123 twz123 marked this pull request as ready for review December 5, 2024 10:35
@twz123 twz123 requested review from a team as code owners December 5, 2024 10:35
@twz123 twz123 requested review from kke and juanluisvaladas December 5, 2024 10:35
@twz123 twz123 merged commit b58ebc6 into k0sproject:main Dec 5, 2024
90 checks passed
@twz123 twz123 deleted the reuse-er-condition branch December 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants