-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add renovate #5238
base: main
Are you sure you want to change the base?
add renovate #5238
Conversation
Thanks for looking into this! Unfortunately, it's not that easy to generate proper version bumps for most of the stuff in the Makefiles. I'd like to start with something really simple first, and then add more and more stuff to it. How about starting with just Alpine (as I think this is the only one that can be done by solely incrementing stuff in the Makefile), so that we have the skeleton and a simple example, and then add other stuff to it in individual PRs? I imagine that we need to restructure things a bit on a case by case basis for automatic version bumps to be working reliably. |
7364a45
to
34a66e3
Compare
9dc7eb9
to
2b20f96
Compare
Thanks @twz123, I'll update the PR to focus on Renovate on-boarding and Alpine only. Once that's in place, we can add other dependencies gradually in separate PRs. Appreciate the guidance! |
The PR is marked as stale since no activity has been recorded in 30 days |
{ | ||
"customType": "regex", | ||
"fileMatch": ["embedded-bins/Makefile.variables"], | ||
"matchStrings": ["alpine_version\\s*=\\s*(?<currentValue>\\S+)"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remembering that we distinguish between the full Alpine version (x.y.z) and only the major/minor part (x.y), so I think we need to augment this?
Description
Adding Renovate so to automate the checks and updates packages dependencies in the embedded-bins/Makefiles.variables
Fixes # (issue)
Type of change
How Has This Been Tested?
The version of the packages version were modified to an earlier version and renovate was run https://github.com/PrashantR30/go_app_3/pulls and we could see the checks were done and PR created for new versions of the depencencies
Checklist: