Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unparam linter #5234

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Enable unparam linter #5234

merged 2 commits into from
Nov 18, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 12, 2024

Description

... and fix lints on the way.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Nov 12, 2024
@twz123 twz123 marked this pull request as ready for review November 12, 2024 17:09
@twz123 twz123 requested review from a team as code owners November 12, 2024 17:09
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123 twz123 force-pushed the unparam branch 3 times, most recently from 56b7884 to e8e848c Compare November 13, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

kke
kke previously approved these changes Nov 14, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

twz123 and others added 2 commits November 15, 2024 10:46
@twz123
Enable unparam linter
4280a0d 
... and fix lints on the way.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 @kke
Update internal/pkg/file/atomic_test.go
82240fa 
Co-authored-by: Kimmo Lehto <[email protected]>
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 enabled auto-merge November 15, 2024 14:14
@twz123 twz123 merged commit a3a0ed0 into k0sproject:main Nov 18, 2024
89 checks passed
@twz123 twz123 deleted the unparam branch November 18, 2024 08:06
@twz123 twz123 mentioned this pull request Nov 18, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke kke approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @kke