Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable perfsprint linter #5224

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Enable perfsprint linter #5224

merged 2 commits into from
Nov 15, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 12, 2024

Description

... and fix lints on the way.

Most of the fixes are straightforward replacements of fmt.Errorf with errors.New and string concatenations instead of fmt.Sprintf with a single leading or trailing %s. Single integer conversions have been replaced with the corresponding functions from the strconv package. Used path.Join, filepath.Join and url.URL where it made sense.

Only add reset and status subcommands on Linux. They were erroring out on Windows, so remove the OS checks from the
commands and only add them on OSes on which they are supported.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Nov 12, 2024
@twz123 twz123 force-pushed the perfsprint branch 2 times, most recently from 090e08c to b5431ed Compare November 12, 2024 14:13
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

kke
kke reviewed Nov 13, 2024
View reviewed changes
cmd/api/api.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123 twz123 marked this pull request as ready for review November 14, 2024 18:24
@twz123 twz123 requested review from a team as code owners November 14, 2024 18:24
@twz123 twz123 requested review from ncopa and makhov November 14, 2024 18:24
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Only add reset and status subcommands on Linux
662d1e8 
They were erroring out on Windows, so remove the OS checks from the
commands and only add them on OSes on which they are supported.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Enable perfsprint linter
c0bc069 
... and fix lints on the way.

Most of the fixes are straightforward replacements of fmt.Errorf with
errors.New and string concatenations instead of fmt.Sprintf with a
single leading or trailing %s. Single integer conversions have been
replaced with the corresponding functions from the strconv package. Used
path.Join, filepath.Join and url.URL where it made sense.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit c4feec0 into k0sproject:main Nov 15, 2024
88 of 89 checks passed
@twz123 twz123 deleted the perfsprint branch November 15, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke kke approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @kke