-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env variables propagation to k0s service #5128
Conversation
Systemd script was reading the environment variables in the wrong way, so the environment variables were not propagated to the k0s service. Signed-off-by: Adrian Pedriza <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we're using .Option['Environment']
for some reason instead of the EnvVars
provided in the service struct.
Since the effort to get rid of the kardianos/service dependency here and test these fix (correct init script generation) involve the integration with it, it has been decided to add tests about the correct init script generation in the future PR after having manually tested the correct functioning of this fix |
Git push to origin failed for release-1.28 with exitcode 1 |
1 similar comment
Git push to origin failed for release-1.28 with exitcode 1 |
Successfully created backport PR for |
Git push to origin failed for release-1.28 with exitcode 1 |
Git push to origin failed for release-1.29 with exitcode 1 |
Git push to origin failed for release-1.29 with exitcode 1 |
Successfully created backport PR for |
Git push to origin failed for release-1.29 with exitcode 1 |
Git push to origin failed for release-1.30 with exitcode 1 |
1 similar comment
Git push to origin failed for release-1.30 with exitcode 1 |
Successfully created backport PR for |
Git push to origin failed for release-1.30 with exitcode 1 |
Git push to origin failed for release-1.31 with exitcode 1 |
2 similar comments
Git push to origin failed for release-1.31 with exitcode 1 |
Git push to origin failed for release-1.31 with exitcode 1 |
Successfully created backport PR for |
Systemd script was reading the environment variables in the wrong way, so the environment variables were not propagated to the k0s service.
Description
Type of change
How Has This Been Tested?
Checklist: