Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env variables propagation to k0s service #5128

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

apedriza
Copy link
Contributor

@apedriza apedriza commented Oct 21, 2024

Systemd script was reading the environment variables in the wrong way, so the environment variables were not propagated to the k0s service.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Systemd script was reading the environment variables in the wrong way, so the environment variables were not propagated to the k0s service.

Signed-off-by: Adrian Pedriza <[email protected]>
@apedriza apedriza requested review from a team as code owners October 21, 2024 07:51
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we're using .Option['Environment'] for some reason instead of the EnvVars provided in the service struct.

@apedriza apedriza marked this pull request as draft October 21, 2024 11:53
@apedriza apedriza marked this pull request as ready for review October 22, 2024 08:52
@apedriza
Copy link
Contributor Author

Since the effort to get rid of the kardianos/service dependency here and test these fix (correct init script generation) involve the integration with it, it has been decided to add tests about the correct init script generation in the future PR after having manually tested the correct functioning of this fix

@apedriza apedriza merged commit 0962379 into k0sproject:main Oct 22, 2024
89 checks passed
@makhov makhov added backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch labels Oct 22, 2024
@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.28 with exitcode 1

1 similar comment
@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.28 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Successfully created backport PR for release-1.28:

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.28 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.29 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.29 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Successfully created backport PR for release-1.29:

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.29 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.30 with exitcode 1

1 similar comment
@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.30 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Successfully created backport PR for release-1.30:

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.30 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.31 with exitcode 1

2 similar comments
@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.31 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Git push to origin failed for release-1.31 with exitcode 1

@k0s-bot
Copy link

k0s-bot commented Oct 22, 2024

Successfully created backport PR for release-1.31:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants