-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-1.28] Bump Go to v1.22.5 #4824
Merged
twz123
merged 8 commits into
k0sproject:release-1.28
from
twz123:backport-4823-to-release-1.28
Aug 5, 2024
Merged
[Backport release-1.28] Bump Go to v1.22.5 #4824
twz123
merged 8 commits into
k0sproject:release-1.28
from
twz123:backport-4823-to-release-1.28
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
added
chore
backport/release-1.27
PR that needs to be backported/cherrypicked to release-1.27 branch
labels
Jul 31, 2024
twz123
force-pushed
the
backport-4823-to-release-1.28
branch
from
July 31, 2024 06:16
fb2ad13
to
63bd34c
Compare
https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.14.0 This cherry-pick fixes a segfault in controller-gen when compiled with Go 1.22: panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa0a8be] goroutine 161 [running]: go/types.(*Checker).handleBailout(0xc00035b200, 0xc000c8bd40) /usr/local/go/src/go/types/check.go:367 +0x88 panic({0xbc39e0?, 0x12ab4e0?}) /usr/local/go/src/runtime/panic.go:770 +0x132 go/types.(*StdSizes).Sizeof(0x0, {0xdbec58, 0x12b3cc0}) /usr/local/go/src/go/types/sizes.go:228 +0x31e go/types.(*Config).sizeof(...) /usr/local/go/src/go/types/sizes.go:333 go/types.representableConst.func1({0xdbec58?, 0x12b3cc0?}) /usr/local/go/src/go/types/const.go:76 +0x9e go/types.representableConst({0xdc4fb0, 0x127ec60}, 0xc00035b200, 0x12b3cc0, 0x0) /usr/local/go/src/go/types/const.go:92 +0x192 go/types.(*Checker).arrayLength(0xc00035b200, {0xdc3258, 0xc0013007e0?}) /usr/local/go/src/go/types/typexpr.go:510 +0x2d3 go/types.(*Checker).typInternal(0xc00035b200, {0xdc1878, 0xc001302d50}, 0x0) /usr/local/go/src/go/types/typexpr.go:299 +0x49d go/types.(*Checker).definedType(0xc00035b200, {0xdc1878, 0xc001302d50}, 0xc000c8b328?) /usr/local/go/src/go/types/typexpr.go:180 +0x37 go/types.(*Checker).varType(0xc00035b200, {0xdc1878, 0xc001302d50}) /usr/local/go/src/go/types/typexpr.go:145 +0x25 go/types.(*Checker).structType(0xc00035b200, 0xc000670630, 0xc000670630?) /usr/local/go/src/go/types/struct.go:113 +0x19f go/types.(*Checker).typInternal(0xc00035b200, {0xdc17e8, 0xc001304210}, 0xc000a546e0) /usr/local/go/src/go/types/typexpr.go:316 +0x1345 go/types.(*Checker).definedType(0xc00035b200, {0xdc17e8, 0xc001304210}, 0xc8cf2e?) /usr/local/go/src/go/types/typexpr.go:180 +0x37 go/types.(*Checker).typeDecl(0xc00035b200, 0xc000a546e0, 0xc000c7e800, 0x0) /usr/local/go/src/go/types/decl.go:615 +0x44d go/types.(*Checker).objDecl(0xc00035b200, {0xdca418, 0xc000a546e0}, 0x0) /usr/local/go/src/go/types/decl.go:197 +0xa7f go/types.(*Checker).packageObjects(0xc00035b200) /usr/local/go/src/go/types/resolver.go:681 +0x425 go/types.(*Checker).checkFiles(0xc00035b200, {0xc00109db90, 0x3, 0x3}) /usr/local/go/src/go/types/check.go:408 +0x1a5 go/types.(*Checker).Files(...) /usr/local/go/src/go/types/check.go:372 sigs.k8s.io/controller-tools/pkg/loader.(*loader).typeCheck(0xc0002873b0, 0xc000329aa0) /run/k0s-build/go/mod/sigs.k8s.io/[email protected]/pkg/loader/loader.go:286 +0x36a sigs.k8s.io/controller-tools/pkg/loader.(*Package).NeedTypesInfo(0xc000329aa0) /run/k0s-build/go/mod/sigs.k8s.io/[email protected]/pkg/loader/loader.go:99 +0x39 sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check(0xc00056f320, 0xc000329aa0) /run/k0s-build/go/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:268 +0x2b7 sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check.func1(0x54?) /run/k0s-build/go/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:262 +0x53 created by sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check in goroutine 129 /run/k0s-build/go/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:260 +0x1c5 Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit fb02476)
https://go.dev/doc/go1.22 Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 364e467) (cherry picked from commit 095bb94)
https://groups.google.com/g/golang-announce/c/5pwGVUPoMbg/m/46oA5yPABQAJ https://go.dev/doc/devel/release#go1.22.1 https://github.com/golang/go/issues?q=milestone%3AGo1.22.1+label%3ACherryPickApproved Fixes CVE-2024-24783, CVE-2023-45290, CVE-2023-45289, CVE-2024-24785 and CVE-2024-24784. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 37a9621) (cherry picked from commit 162af54)
https://groups.google.com/g/golang-announce/c/YgW0sx8mN3M/m/khALNYGdAAAJ https://go.dev/doc/devel/release#go1.22.2 https://github.com/golang/go/issues?q=milestone%3AGo1.22.2+label%3ACherryPickApproved Fixes CVE-2023-45288. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 308712c) (cherry picked from commit cd7d5f5)
https://groups.google.com/g/golang-announce/c/wkkO4P9stm0/m/IcuqZRViCgAJ https://go.dev/doc/devel/release#go1.22.3 https://github.com/golang/go/issues?q=milestone%3AGo1.22.3+label%3ACherryPickApproved Fixes CVE-2024-24787 and CVE-2024-24788. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 7b700d8) (cherry picked from commit c2ddb50)
twz123
force-pushed
the
backport-4823-to-release-1.28
branch
2 times, most recently
from
July 31, 2024 08:04
318fce5
to
1525b9f
Compare
twz123
force-pushed
the
backport-4823-to-release-1.28
branch
from
July 31, 2024 08:27
1525b9f
to
5dab678
Compare
Upstream no longer supports Alpine 3.18. Any further Go version bumps will require a newer Alpine version. See: 05a498b ("Update to Alpine 3.19.0") Signed-off-by: Tom Wieczorek <[email protected]>
https://groups.google.com/g/golang-announce/c/XbxouI9gY7k/m/TuoGEhxIEwAJ https://go.dev/doc/devel/release#go1.22.4 https://github.com/golang/go/issues?q=milestone%3AGo1.22.4+label%3ACherryPickApproved Fixes CVE-2024-24789 and CVE-2024-24790. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 6887836) (cherry picked from commit 337891e) (cherry picked from commit 472540b)
https://groups.google.com/g/golang-announce/c/gyb7aM1C9H4 https://go.dev/doc/devel/release#go1.22.5 https://github.com/golang/go/issues?q=milestone%3AGo1.22.5+label%3ACherryPickApproved Fixes CVE-2024-24791. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 1f9ca4b) (cherry picked from commit dc7fb5a) (cherry picked from commit f0af347)
twz123
force-pushed
the
backport-4823-to-release-1.28
branch
from
July 31, 2024 13:10
5dab678
to
28b3910
Compare
ncopa
approved these changes
Aug 5, 2024
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.27
git worktree add -d .worktree/backport-4824-to-release-1.27 origin/release-1.27
cd .worktree/backport-4824-to-release-1.27
git checkout -b backport-4824-to-release-1.27
ancref=$(git merge-base 286952feb390b3342a3aeb69af1bebc39f7100fd 28b3910da3fcfe1e484c786989cacc0f61414ab0)
git cherry-pick -x $ancref..28b3910da3fcfe1e484c786989cacc0f61414ab0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.29
:See:
Upstream Kubernetes did the same. This PR switches to Alpine 3.19 for compiling k0s in 390068f.