Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Kubernetes REST client for joining #4653

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 18, 2024

Description

This makes the code a lot easier.

Augment the unit tests for the JoinClient with the happy cases, so that there's test coverage for this change:

  • Capture new member node names in etcd controller. This moves the side effect of the os.Hostname() call out of the client, so that it doesn't influence the tests.
  • Change the fake HTTP server to HTTPS, which will test the certificate handling properly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Jun 18, 2024
This moves the side effect of the os.Hostname call out of the client,
and leaves this up to the etcd controller.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the rest-joinclient branch 2 times, most recently from 20ffdff to 7cb39cb Compare June 18, 2024 08:15
twz123 added 2 commits June 18, 2024 11:06
This includes changing the fake HTTP server to HTTPS. This will test the
certificate handling properly.

Signed-off-by: Tom Wieczorek <[email protected]>
This makes the code a lot easier.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the rest-joinclient branch from 7cb39cb to 2676a27 Compare June 18, 2024 09:06
@twz123 twz123 marked this pull request as ready for review June 18, 2024 13:06
@twz123 twz123 requested a review from a team as a code owner June 18, 2024 13:06
@twz123 twz123 requested review from ncopa and juanluisvaladas June 18, 2024 13:06
@twz123 twz123 merged commit bc88876 into k0sproject:main Jun 21, 2024
79 checks passed
@twz123 twz123 deleted the rest-joinclient branch June 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants