Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make builtins to split the Kubernetes version #4638

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 17, 2024

Description

Makes it more self-contained.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Makes it more self-contained.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the chore label Jun 17, 2024
@twz123 twz123 marked this pull request as ready for review June 17, 2024 18:06
@twz123 twz123 requested a review from a team as a code owner June 17, 2024 18:06
@twz123 twz123 requested review from ncopa and juanluisvaladas June 17, 2024 18:06
Copy link
Collaborator

@ncopa ncopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid forking a shell is also better for performance.

@twz123 twz123 merged commit b4aea3a into k0sproject:main Jun 25, 2024
80 checks passed
@twz123 twz123 deleted the mf-word branch June 25, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants