Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct version number in containerd CRI config #4568

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Set correct version number in containerd CRI config #4568

merged 1 commit into from
Jun 7, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 7, 2024

Description

The version number has to be lowercase, otherwise it won't be picked up by containerd. If the version is missing, containerd might not do the right thing when merging configuration values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Set correct version number in containerd CRI config
15b0427 
The version number has to be lowercase, otherwise it won't be picked up
by containerd. If the version is missing, containerd might not do the
right thing when merging configuration values.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/configuration component/containerd backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Jun 7, 2024
@twz123 twz123 requested a review from a team as a code owner June 7, 2024 08:18
@twz123 twz123 requested review from ncopa and jnummelin June 7, 2024 08:18
@twz123 twz123 merged commit 4d24f74 into k0sproject:main Jun 7, 2024
82 checks passed
@twz123 twz123 deleted the containerd-toml-lowercase-version branch June 7, 2024 09:03
@k0s-bot
Copy link

k0s-bot commented Jun 7, 2024

Successfully created backport PR for release-1.30:

@k0s-bot k0s-bot mentioned this pull request Jun 7, 2024
Merged
@twz123 twz123 mentioned this pull request Jun 11, 2024
Merged
@k0s-bot k0s-bot mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/configuration backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working component/containerd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @jnummelin