Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the wrong default timeout from the Helm docs #4566

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 6, 2024

Description

For both Chart and ClusterConfig resources, the timeout field has never had a default.

Type of change

  • [x Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

For both Chart and ClusterConfig resources, the timeout field has never
had a default.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working documentation Improvements or additions to documentation backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Jun 6, 2024
@twz123 twz123 requested a review from a team as a code owner June 6, 2024 14:16
@twz123 twz123 requested review from ncopa and jnummelin June 6, 2024 14:16
@twz123 twz123 merged commit 812d081 into k0sproject:main Jun 6, 2024
10 checks passed
@twz123 twz123 deleted the docs-helm-timeout branch June 6, 2024 17:55
@k0s-bot
Copy link

k0s-bot commented Jun 6, 2024

Successfully created backport PR for release-1.30:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants