-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document constraints of dynamic config install #4559
Conversation
Non-changeable fields can cause issues if not defined in the configuration file. This isn't immediately obvious by reading the docs so document it explicitly. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
Tagged it to backport to 1.30 only because the older versions need a manual backport due to CPLB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's anything stopping us from actually supporting this to be dynamically reconciled? It currently feels like all that is needed is to add a Reconcile
method to the Keepalived
struct.
I discussed this with Jussi back in the day and we agreed we didn't want to support this because: |
I don't see why kube-apiserver is relying on that? If yes, then because users have actively configured it in that way.
Right. Currently, k0s is only able to reconcile cluster-wide settings. Maybe that's something to be revisited in the future. |
This is used to fill the SANs of the kube-apiserver certificate. I think that was the only thing where it affected apiserver. |
Successfully created backport PR for |
Description
I got a report of someone who had issues becuase the
kubernetes.default.svc
clusterIP
was missing from the SANs of some control plane nodes. This happened because the certificate for kube-apiserver is generated without dynamic config. In the past we saw a similar issue with specifyingspec.network.provider
, but because it was reported in k0sctl we only fixed it for k0sctl.We don't document anywhere this behavior but we copy it in k0sctl and in k0smotron we use the same configuration for every replica of the statefulset, we should tell .
Non-changeable fields can cause issues if not defined in the configuration file. This isn't immediately obvious by reading the docs so document it explicitly.
This was in the past
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist: